skillZs
★ LIVE SKILL TAGS ★
>>> LIVE SKILLS INDEX <<<
* OPEN SOURCE *
NO LOGIN, NO TRACKING
※ REAL INSTALL DATA ※
← back to all skills
saleor/configurator62 installs

reviewing-typescript-code

Reviews TypeScript code for project-specific quality patterns. Use when writing entities, services, repositories, comparators, formatters, bootstrap methods, deployment stages, diff support, or reviewing PRs with functional patterns. Do NOT use for general TypeScript tutorials or non-Configurator projects.

How do I install this agent skill?

npx skills add https://github.com/saleor/configurator --skill reviewing-typescript-code
view source ↗

Is this agent skill safe to install?

  • Gen Agent Trust Hubpass

    The skill provides comprehensive guidelines for project-specific TypeScript code quality reviews. No direct malicious behaviors were found; however, the skill is classified as low risk because it is designed to analyze external source code, creating an attack surface for indirect prompt injection via embedded instructions in comments or literals.

  • Socketpass

    No alerts

  • Snykpass

    Risk: LOW · No issues

  • Runlayerwarn

    3/3 files flagged

What does this agent skill do?

TypeScript Code Quality Patterns

Overview

Project-specific code quality checklist for the Saleor Configurator codebase. Covers type safety conventions, error handling patterns, and architectural standards unique to this project.

When to Use

  • Adding entity types, services, repositories, comparators, formatters
  • Implementing deployment stages or bootstrap methods
  • Creating Zod schemas or error classes
  • Reviewing code before commit or PR merge

Quick Reference

ConventionRule
No anyProduction code only; allowed in test mocks
Branded typesUse EntitySlug, EntityName for domain values
Error classesExtend BaseError with error code
GraphQL errorsWrap with GraphQLError.fromCombinedError()
Zod errorsWrap with ZodValidationError.fromZodError()
Functions10-50 lines ideal, ~100 max
StyleFunctional (map/filter/flatMap) over loops

Quality Checklist

Type Safety

  • No any types in production code
  • No unsafe assertions (as unknown as T)
  • No non-null assertions (!) without justification
  • Branded types for domain values (EntitySlug, EntityName)
  • Discriminated unions over inheritance
  • satisfies for type validation with literal preservation
  • readonly for immutable data

Clean Code

  • Single responsibility per function
  • Functions under 50 lines (ideally)
  • Meaningful, declarative names
  • Boolean names use is/has/should/can prefix
  • Named constants instead of magic numbers
  • Registry/strategy pattern for long conditional chains
  • Arrow functions for consistency

Functional Patterns

  • No direct mutation of arrays/objects
  • map/filter/flatMap over for/forEach loops
  • No accumulating spreads in reduce (use Map)

Error Handling

  • Custom errors extend BaseError with error code
  • GraphQL errors: GraphQLError.fromCombinedError()
  • Zod errors: ZodValidationError.fromZodError()
  • Error messages are actionable with recovery suggestions
  • Error includes relevant context

Review Output Format

Structure findings as:

Critical Issues

Items that must be fixed before merge.

Important Improvements

Items that should be addressed but are not blocking.

Suggestions

Nice-to-have improvements for future consideration.

Positive Observations

Well-implemented patterns worth highlighting.

Project-Specific Conventions

  • Entity identification: Slug-based (categories, products) vs Name-based (productTypes, pageTypes)
  • Service pattern: Constructor DI with validator, repository, logger
  • Repository pattern: GraphQL operations encapsulated, responses mapped to domain models
  • Test pattern: vi.fn() mocks with schema-generated test data
  • Zod-first: Define schemas before implementing logic; use z.infer<> for types

Common Mistakes

MistakeFix
Using any in production codeUse unknown + type guards
Exposing GraphQL types to servicesMap to domain types in repository
Missing error context in GraphQL callsInclude operation name in error
Long if-else chainsRefactor to registry/strategy pattern
Accumulating spreads in reduceUse Map or Object.fromEntries
Mutation in loops (push)Use map/filter/flatMap

References

Skill Reference Files

Project Resources

  • docs/CODE_QUALITY.md - Complete coding standards
  • docs/ARCHITECTURE.md - Service patterns
  • biome.json - Linting rules

Related Skills

  • Complete entity workflow: See adding-entity-types for architectural patterns
  • Zod standards: See designing-zod-schemas for schema review criteria
  • Pre-commit checks: See validating-pre-commit for quality gate commands

Quick Reference Rule

For a condensed quick reference, see .claude/rules/code-quality.md (automatically loaded when editing src/**/*.ts files).

Add the canonical catalog link to the repository README so users can inspect current installs and available audits. The publishing guide covers the complete discovery path.

<a href="https://skillzs.dev/skills/saleor/configurator/reviewing-typescript-code">View reviewing-typescript-code on skillZs</a>